Add get_parameter_or overload returning value or alternative #2973
+41
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r alternative Signed-off-by: Zheng Qu <[email protected]>
Maverobot
force-pushed
the
add-get-parameter-or-for-lifecyclenode
branch
from
f7aa101 to
8ffcf53
Compare
fujitatomoya
requested changes
Nov 1, 2025
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
I think that is just fine to have this methods in LifecycleNode to keep the consistency with Node under current design.
can you also add the test to make sure this method works?
Signed-off-by: Zheng Qu <[email protected]>
Contributor
Author
|
Adding tests makes total sense. A new test has now been pushed in a separate commit. |
fujitatomoya
approved these changes
Nov 7, 2025
Collaborator
|
Pulls: #2973
|
ahcorde
approved these changes
Nov 7, 2025
Contributor
|
@fujitatomoya do we need to backport this one ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LifecycleNodeis missing aget_parameter_orpublic function, which exists inNode.Is this user-facing behavior change?
Yes. It makes the behavior of
LifecycleNodemore consistent withNode.Did you use Generative AI?
No.